Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for GPUArraysCore to 0.2, (keep existing compat) #1127

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Dec 7, 2024

This pull request changes the compat entry for the GPUArraysCore package from 0.1.6 to 0.1.6, 0.2.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@avik-pal avik-pal force-pushed the compathelper/new_version/2024-12-07-00-18-55-829-01300176854 branch from 3796ede to 18961c1 Compare December 7, 2024 00:19
Copy link
Contributor Author

github-actions bot commented Dec 7, 2024

Benchmark Results (ASV)

main e306caf... main/e306caf33078e3...
basics/overhead 0.156 ± 0.0019 μs 0.125 ± 0.0015 μs 1.25
time_to_load 0.914 ± 0.0088 s 0.902 ± 0.0019 s 1.01

Benchmark Plots

A plot of the benchmark results have been uploaded as an artifact to the workflow run for this PR.
Go to "Actions"->"Benchmark a pull request"->[the most recent run]->"Artifacts" (at the bottom).

@avik-pal
Copy link
Member

avik-pal commented Dec 7, 2024

We need to wait till CUDA supports GPUArraysCore 0.2 else our testing failing

@avik-pal avik-pal force-pushed the compathelper/new_version/2024-12-07-00-18-55-829-01300176854 branch from 18961c1 to 319d114 Compare January 8, 2025 13:37
@avik-pal
Copy link
Member

avik-pal commented Jan 8, 2025

we still need a new version for cuDNN

@avik-pal avik-pal force-pushed the compathelper/new_version/2024-12-07-00-18-55-829-01300176854 branch from 99eff53 to e306caf Compare January 11, 2025 18:29
@avik-pal avik-pal merged commit 57120a0 into main Jan 11, 2025
34 of 47 checks passed
@avik-pal avik-pal deleted the compathelper/new_version/2024-12-07-00-18-55-829-01300176854 branch January 11, 2025 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant